Song 494 remove analysis ids #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Prevent duplicate analyses from being created | ||
| checkServer( | ||
| !isAnalysisExist(candidateAnalysisId), | ||
| !isAnalysisExist(analysisId), |
There was a problem hiding this comment.
In the (very unlikely) even that there is a random number collision, there's nothing the user can do about it.
Either remove the check, or, if you're paranoid enough, wrap it in a while(collision) { generate_new_random_number()} type loop.
| @@ -56,20 +57,7 @@ public SubmitResponse submit( | |||
| @RequestHeader(value = AUTHORIZATION, required = false) final String accessToken, | |||
| @PathVariable("studyId") String studyId, | |||
| @RequestBody @Valid String json_payload) { | |||
| return uploadService.submit(studyId, json_payload, false); | |||
| return uploadService.submit(studyId, json_payload); | |||
There was a problem hiding this comment.
Should check to make sure the client code and sdk examples match the server changes.
Specifically, I noticed song-python-sdk/examples/example_upload.py, line 76 still has "ignore_analysis_id_collisions" as a parameter to api.save.
There was a problem hiding this comment.
thank you for the reminder. I completely forgot lol
KevinFHartmann
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Remove the option for user supplied analysisIds #494